View Single Post
Old 09-06-2008, 02:59 PM   #8
magneum
Registered User
 
Last Online: 01-01-2009 03:15 AM
Join Date: Apr 2008
Posts: 48
Rep Power: 0
Rep Points: 11
magneum is on a distinguished road
Feedback: (0)
Points: 8,466.20
Bank: 0.00
Total Points: 8,466.20
Re: Final Notepad, Better than Wordpad, fast easy and reliable!

Quote:
Originally Posted by LCS View Post
The lack of source code didn't stop me, and here's my opinion:
  • Good
    • Using encryption (although whether you're using it properly or not has yet to be determined)
    • You're handling error conditions with a Try/Catch block (although I could be wrong and it's only the compiler putting them in for you).
  • Bad
    • You're not using exception handlers for their intended purpose. You could have used other means to determine if a password was incorrect, rather than letting an exception be thrown. An exception is just what its name implies: it happens in exceptional conditions! Somebody mistyping a password certainly isn't exceptional…
    • The login system is pointless since it makes the application harder to use. Windows already makes the user log in, and if a user is able to use you're program, you should assume he or she has the proper credentials to view the information. You could however, transparently encrypt the user's data without asking for a password using the Windows user key. Check out the .NET Framework's DPAPI (Data Protection Application Programming Interface) provided through the classes ProtectedData and ProtectedMemory in the System.Security.Cryptography namespace.
    • Bundling a word processor and a browser doesn't really make sense…
That's what I could determine by skimming your program code quickly. Your program, however, never ran; it crashed on startup, so I never got to see it in action.


how can you view the source?
magneum is offline   Reply With Quote